Conversation
PRs can be labelled and "milestone'd" as well as just commented on, which get exposed issue events. Here, broaden the terms of this condition to cover all of those events.
webbnh
approved these changes
Jan 24, 2025
Collaborator
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
This change looks OK to me, although Black will not be happy with it, if #280 gets merged first.
However, in order for this to work properly, I believe that this branch/PR should include commit efb0a01, which is currently in #280 but which should really be in this PR instead.
Also, we need to consider whether this change as presented is sufficient, or whether we need to tweak the condition in handle_github_message().
azhuzhu
pushed a commit
to azhuzhu/Sync2Jira
that referenced
this pull request
Mar 17, 2025
PRs can be labelled and "milestone'd" as well as just commented on, which get exposed issue events. Here, broaden the terms of this condition to cover all of those events.
azhuzhu
pushed a commit
to azhuzhu/Sync2Jira
that referenced
this pull request
Mar 18, 2025
PRs can be labelled and "milestone'd" as well as just commented on, which get exposed issue events. Here, broaden the terms of this condition to cover all of those events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs can be labelled and "milestone'd" as well as just commented on, which get exposed issue events. Here, broaden the terms of this condition to cover all of those events.